Bug #71

Webserver invalid protocol.

Added by chrashoverraid over 1 year ago. Updated over 1 year ago.

Status: Closed Start: 01/19/2011
Priority: Normal Due date:
Assigned to: Alguno % Done:

0%
Category: JSON-RPC plugin
Target version: -
Votes: 0

Description

When using fiddler to log some traffic i saw some errors.

The errors are showing when opening the NNTPGrab webinterface (in Firefox). However, Firefox seems to handle the protocol violation.
When trying to connect to the NNTPGrab server through C#, it isn't working, an exception occurs (in C#). This is most likely due to the error fiddler is showing.

The error is:
Fiddler has detected a protocol violation in session #7.

No Connection: close, no Content-Length. No way to tell if the response is complete.

I've added a log with the raw request and response data.
Note: I'm using a slightly modified version of the json-rpc plugin. I disabled the mongoose url protection, that's why no auth header is present.

raw_data.txt (700 Bytes) chrashoverraid, 01/19/2011 09:45 am

History

#1 Updated by Alguno over 1 year ago

  • Status changed from New to Closed

This protocol violation seems to be caused by your own changes to the JSON-RPC plugin:

Index: plugins/jsonrpc/plugin_webserver.c ===================================================================
--- plugins/jsonrpc/plugin_webserver.c (revision 1812)
+++ plugins/jsonrpc/plugin_webserver.c (working copy)

@ -332,6 +337,43 @
}

static void
process_jsonrpc_request_unprotected(struct mg_connection *conn, const struct mg_request_info *request_info, void *user_data)
{
+ char *response;
+ char post_data[1024];

 mg_printf(conn, "%s", "HTTP/1.1 200 OK\r\n");
+ mg_printf(conn, "%s", "Content-Type: text/plain\r\n\r\n");

 if (strcmp(request_info->request_method, "POST") ||
<snip>

There are no other places in the JSON-RPC code where only the Content-Type header is returned in the response (and no other headers)

#2 Updated by chrashoverraid over 1 year ago

    I just tried it again without any changes, error still occurs.

    #3 Updated by chrashoverraid over 1 year ago

      Can't edit my message and can't reopen this issue, so i create a new one.

      Also available in: Atom PDF