Bug #79

Crash on prepared request

Added by chrashoverraid almost 5 years ago. Updated almost 5 years ago.

Status: Closed Start: 07/03/2011
Priority: Normal Due date:
Assigned to: Alguno % Done:

100%
Category: JSON-RPC plugin
Target version: 0.7.0
Votes: 0

Description

When performing a special request the GUI crashes.
I know the request is invalid, but the program crashes.

When posting a message with only: "nntpgrab_get_version_info" without the "{}" brackets and no "method" field, the GUI crashes.
Expected result is a invalid request or something.

When posting the message like this, I get a result as expected: { "method": "nntpgrab_get_version_info", "params": null, "id":1 }

bt.txt (1.2 KB) chrashoverraid, 07/03/2011 06:28 pm

Associated revisions

Revision 1838
Added by Alguno almost 5 years ago

- Don't crash when in invalid jsonrpc request is being parsed. Closes #79
- Added a testcase for this crash

History

  • File bt.txt added

#2 Updated by Alguno almost 5 years ago

  • Category set to JSON-RPC plugin
  • Status changed from New to In Progress
  • Target version set to 0.7.0

Thanks for the bugreport. I managed to reproduce it. Fix will follow soon

#3 Updated by Alguno almost 5 years ago

  • Status changed from In Progress to Closed
  • % Done changed from 0 to 100

Applied in changeset r1838.

Snapshots can be found at the following URLs:
Win32: https://snapshots.nntpgrab.nl/win32/unstable-trunk/nntpgrab_trunk_snapshot_svn_r1838_setup.exe
Win64: https://snapshots.nntpgrab.nl/win64/unstable-trunk/nntpgrab_trunk_snapshot_svn_r1838_setup_x64.exe
Mac OS X: https://snapshots.nntpgrab.nl/osx/unstable-trunk/NNTPGrab_unstable_r1838.zip

Also available in: Atom PDF