Bug #74

Reopen: Webserver invalid protocol

Added by chrashoverraid about 2 years ago. Updated about 2 years ago.

Status: Closed Start: 03/14/2011
Priority: Normal Due date:
Assigned to: Alguno % Done:

100%
Category: JSON-RPC plugin
Target version: -
Votes: 0

Description

Issue 71 https://www.nntpgrab.nl/issues/71 is closed, but it isn't fixed.
I just tested it with snapshot 1817 and the default jsonrpc plugin.

I couldn't find a way to reopen the issue, so i created a new one.

btw: nntpgrab qt is broken with latest snapshot.

patch.diff (1.5 KB) chrashoverraid, 03/14/2011 11:50 pm

Associated revisions

Revision 1819
Added by Alguno about 2 years ago

- Convert all strings coming from the NNTPGrab Core to the Qt Frontend
to the QString native character encoding (which isn't UTF-8 on Windows).
Fixes an issue where names of collections and files could get malformed
if they contain non-UTF8 characters. Closes #72
- When importing files with special characters, some invalid JSON-RPC messages
could get sent to external frontends. Fixed
- Add a Content-Length header to HTTP requests in the JSON-RPC plugin
Patch by chrashoverraid. Closes #74
- When connecting to a NNTPGrab Server using the 32bit Windows
frontend, the frontend could crash. Fixed. Closes #70

History

#1 Updated by chrashoverraid about 2 years ago

  • File patch.diff added

Here is a small fix, yes I'm aware that it still has protocol violations.

It still posts:
HTTP/1.1 200 OK
Content-Type: text/plain

This URI should only be used for JSON-RPC requests

Which is wrong, but that bug was already in the code.
The normal post operations are now valid, looking something like this:

HTTP/1.1 200 OK
Content-Type: text/plain
Content-Length: 17

{ "result": [ ] }

#2 Updated by chrashoverraid about 2 years ago

  • Status changed from New to Feedback

#3 Updated by Alguno about 2 years ago

  • Status changed from Feedback to Closed
  • % Done changed from 0 to 100

Applied in changeset r1819.

Snapshots can be found at the following URLs:
Win32: https://snapshots.nntpgrab.nl/win32/unstable-trunk/nntpgrab_trunk_snapshot_svn_r1819_setup.exe
Win64: https://snapshots.nntpgrab.nl/win64/unstable-trunk/nntpgrab_trunk_snapshot_svn_r1819_setup_x64.exe
Mac OS X: https://snapshots.nntpgrab.nl/osx/unstable-trunk/NNTPGrab_unstable_r1819.zip

#4 Updated by Alguno about 2 years ago

    Bedankt voor je patch!
    De Qt frontend zou nu trouwens ook weer goed moeten werken

    Also available in: Atom PDF